Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unusued inplace param from gibbs_removal() #2756

Closed
wants to merge 1 commit into from

Conversation

tashrifbillah
Copy link
Contributor

Closes issue #2754

Copy link
Member

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tashrifbillah,

Thank you cleaning up!

You might need to update test files and tutorials.
Also, we need to give time to user to remove this parameter from their script.

So, you need to keep the variable and the code, and add it as a deprecated parameter
something like:

@deprecated_params(['num_threads', 'inplace'], ['num_processes', None], since='1.4', until='1.8')

@skoudoro skoudoro closed this Apr 20, 2023
@skoudoro
Copy link
Member

closing in favor of my last comment here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants