MRG: more fixes for windows script tests #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python executable can be in a path with spaces. Quote the discovered python executable just in case.
Windows scripts need executable name, or shell=True. Add .bat to name.
arokem
added a commit
that referenced
this pull request
Jan 15, 2014
MRG: more fixes for windows script tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We got more windows script test failures on the buildbots.
This turned out to be because I had changed the subprocess.Popen command to use
shell=False; if this is the case then windows needs the correct extension for
the executable. Add the '.bat' file extension for the executables on Windows.
Also, quote the Python executable path in case this path has spaces in it.