Add progress bar feature to dipy.data.fetcher #971
Conversation
|
Nice one. +1 from me. Not to bike-shed too much, but it would be nice to have the eventual file-size reported as part of the progress bar (we currently report file size "by hand"). That way, users know what "10%" of the file-size means. |
|
@arokem sure so should I remove
by as a part of progress bar you mean beside it? or above it? |
|
Yes - if we can figure out data_size from the file (apparently you can!), we can get rid of all the places where Maybe put the size of the file right next to the percentage already downloaded? |
|
|
|
This actually looks fine to me. On Tue, Mar 15, 2016 at 8:29 AM, Bishakh Ghosh notifications@github.com
|
|
We'd want to get rid of all the other places that have the data_size. In the definition of https://github.com/nipy/dipy/blob/master/dipy/data/fetcher.py#L88 But also in the definition of individual fetchers. For example: |
…size s Fixes dipy#970 Data size was printed by hand previously i.e hard coded. This is replacing that with the data size from the http response and displaying beside the progressbar.
|
@arokem Made the changes! I hope that does not break anything anywhere else. |
|
Yes. That looks right to me. If anyone else wants to take a look, please do so in the next few days. Otherwise, I will go ahead and merge this. |
Add progress bar feature to dipy.data.fetcher
|
Closes #970 |
Previously file url was used to test the fetcher module. To improve that and make it compatible with the progressbar in fetcher dipy#971 use a local HTTP server to emulate HTTP downloads. modified: tests/test_fetcher.py
Previously file url was used to test the fetcher module. To improve that and make it compatible with the progressbar in fetcher dipy#971 use a local HTTP server to emulate HTTP downloads. modified: tests/test_fetcher.py
fixes #970