FIX: Use absolute imports in testing,tests and segment files #993
Conversation
|
@souravsingh You shouldn't change the init files as arokem warned and I guess it will be better if we work by opening an issue first and then fixing it so that there are no conflicts later with multiple people working on the same thing. All the absolute error issues are referenced in #969 |
|
@sahmed95 Sorry for this. I came to know this very late. |
|
No issues. 😄 Even I had a doubt about this. |
|
Also, I guess you can change segment too along with testing and tests here which will close #1000. |
|
@sahmed95 I have done the segment fixing in the latest commit for the PR |
|
Then I would suggest you update the name of the fix to "Use absolute imports in segment, testing and tests" |
souravsingh
changed the title
| @@ -5,8 +5,8 @@ | |||
| IO_DATA_PATH = abspath(pjoin(dirname(__file__), | |||
| '..', 'io', 'tests', 'data')) | |||
|
|
|||
| from .spherepoints import sphere_points | |||
| from .decorators import doctest_skip_parser | |||
| from dipy.testing.spherepoints import sphere_points | |||
There was a problem hiding this comment.
I'd stay away from __init__ files, for now.
|
Hey @souravsingh - have you had a chance to take a look here? It would be great if you could revert the changes you made in the |
|
My bad, I almost forgot about this.Thanks for reminding |
|
This one needs a rebase. |
|
Could you please rebase this on current master? |
|
Superseded by #1134. Closing |
Changed some of the relative imports in testing and tests to use absolute imports.
Fixes a small part of #969