Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Use absolute imports in io #1005

Merged
merged 6 commits into from Apr 4, 2016
Merged

FIX: Use absolute imports in io #1005

merged 6 commits into from Apr 4, 2016

Conversation

souravsingh
Copy link
Contributor

Changes relative imports to absolute imports.
Fixes #997

@theaverageguy
Copy link
Contributor

I think it should be " from dipy.io import * " @souravsingh . The build is failing.

@theaverageguy
Copy link
Contributor

Please do correct me if I am wrong though. :)

@arokem
Copy link
Contributor

arokem commented Mar 23, 2016

You might want to run the tests locally on your machine before pushing. That way, you don't have to wait for the Travis bot to report on the errors :-)

@quantshah
Copy link
Contributor

the relative import is ... three directories up from dipy.
Can you try this?

from dipy import io

@arokem
Copy link
Contributor

arokem commented Mar 28, 2016

Yeah, I think @sahmed95 is correct.

@theaverageguy
Copy link
Contributor

Will fix in a while.

On Mon, Mar 28, 2016 at 7:47 PM, Ariel Rokem notifications@github.com
wrote:

Yeah, I think @sahmed95 https://github.com/sahmed95 is correct.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#1005 (comment)

@souravsingh
Copy link
Contributor Author

I have made the changes in test_io.py

@arokem
Copy link
Contributor

arokem commented Mar 28, 2016

Did you run the tests on your machine? Did they pass?

@souravsingh
Copy link
Contributor Author

I ran the tests and all of them passed

@arokem
Copy link
Contributor

arokem commented Mar 28, 2016

👍 Great! This now all looks fine to me. I'll wait for feedback from others, and merge in a few days if I don't hear anything.

@arokem arokem merged commit b199e18 into dipy:master Apr 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants