Doc - fix definition of real_sph_harm functions #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $Y^m_n$ if m == 0 | ||
| Imag($Y^m_n$) * sqrt(2) if m < 0 | ||
| Imag($Y^m_n$) * sqrt(2) if m > 0 | ||
| $Y^m_n$ if m == 0 |
There was a problem hiding this comment.
I think that's correct. I believe that we are following the same convention as the one outlined in @mdesco et al.'s 2007 paper (http://onlinelibrary.wiley.com/doi/10.1002/mrm.21277/full). See equation 3. I believe you can write this central line as:
$Y^0_n$ if m=0
I don't think that we need to collapse the index here, as they do in that paper.
There was a problem hiding this comment.
I changed the middle line, does this look better?
|
Any more comments here? I'll merge this in a couple of days, if I don't hear from anyone. |
|
LGTM. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can someone double check me, but I think this is right now.