Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tracking interfaces #1056

Merged
merged 4 commits into from May 23, 2016
Merged

Conversation

MrBago
Copy link
Contributor

@MrBago MrBago commented May 23, 2016

We missed one file in #1054, re-based to make the commits more clear.

@Garyfallidis
Copy link
Contributor

Hi @MrBago There must be a mistake here. You are removing also markov.py and tests/test_markov.py? These are critical parts of the tracking API. Correct me if wrong. Please explain.

@MrBago
Copy link
Contributor Author

MrBago commented May 23, 2016

markov.py was my first attempt at the tracking API. There isn't anything in
markov.py that didn't make it into either dipy.tracking.local or
dipy.direction. Plus the new stuff is in cython so markov.py isn't
compatible with it.

On Sun, May 22, 2016 at 7:31 PM Eleftherios Garyfallidis <
notifications@github.com> wrote:

Hi @MrBago https://github.com/MrBago There must be a mistake here. You
are removing also markov.py and tests/test_markov.py? These are critical
parts of the tracking API. Correct me if wrong. Please explain.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#1056 (comment)

@Garyfallidis
Copy link
Contributor

Okay thanks. Please also give a thumbs up to #1042

@Garyfallidis Garyfallidis merged commit 9a9a4ec into dipy:master May 23, 2016
@arokem arokem mentioned this pull request Jun 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants