Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptive Denoising #1066

Merged
merged 47 commits into from Aug 10, 2016
Merged

Adaptive Denoising #1066

merged 47 commits into from Aug 10, 2016

Conversation

riddhishb
Copy link
Contributor

This branch is for adaptive denoising, currently includes

  1. nlmeans_block.pyx
    for adding a blockwise averaging approach in nlmeans
  2. wavelet.py in dipy.core
  3. ascm.py
    Adaptive soft coefficient matching based denoising

I have also added the keyword to toggle between current voxelwise implementation of nlmeans and the proposed blockwise one.

I am yet to add tests and some examples.

@riddhishb
Copy link
Contributor Author

@Garyfallidis Please have a look at this.

OUTPUT:
y - array x will be shifed by m samples down
along dimension d

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @riddhishb. Please correct docstring to fit the style of our other docstrings.

block_radius=1,
rician=True)

# Now perform the adaptive soft coefficient matching
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this inline comment

@coveralls
Copy link

coveralls commented Aug 8, 2016

Coverage Status

Changes Unknown when pulling c3df90d on riddhishb:adap_denoise into * on nipy:master*.

@coveralls
Copy link

coveralls commented Aug 8, 2016

Coverage Status

Changes Unknown when pulling c3df90d on riddhishb:adap_denoise into * on nipy:master*.

t = time()

"""
The ``ascm`` function takes two denoised inputs, one more smooth than the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First sentence has repeated information.

@coveralls
Copy link

coveralls commented Aug 8, 2016

Coverage Status

Changes Unknown when pulling 05dbed8 on riddhishb:adap_denoise into * on nipy:master*.

@coveralls
Copy link

coveralls commented Aug 8, 2016

Coverage Status

Changes Unknown when pulling 05dbed8 on riddhishb:adap_denoise into * on nipy:master*.

The adaptive soft coefficient matching (ASCM) as described in [Coupe11]_ is a
improved extension of non-local means (NLMEANS) denoising. ASCM gives a better
denoised images from two standard non-local means denoised versions of the
original data with different degrees sharp feature preserved. Here, one
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace this with '... original data with different degrees of sharpness. Here, one... '

@Garyfallidis Garyfallidis changed the title WIP: Adaptive Denoising Adaptive Denoising Aug 9, 2016
@coveralls
Copy link

coveralls commented Aug 9, 2016

Coverage Status

Changes Unknown when pulling 13da3b9 on riddhishb:adap_denoise into * on nipy:master*.

@coveralls
Copy link

coveralls commented Aug 9, 2016

Coverage Status

Changes Unknown when pulling 13da3b9 on riddhishb:adap_denoise into * on nipy:master*.

@RafaelNH
Copy link
Contributor

RafaelNH commented Aug 9, 2016

I haven't any further comments on the documentation - for me this can be merged! Please let me know asap if anyone have any comments to this PR. We are planning to merge this at the end of this day!

@RafaelNH RafaelNH merged commit b0b74d6 into dipy:master Aug 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants