-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation uploading script #1082
Add documentation uploading script #1082
Conversation
Current coverage is 80.96% (diff: 100%)@@ master #1082 diff @@
==========================================
Files 205 205
Lines 23329 23329
Methods 0 0
Messages 0 0
Branches 2341 2341
==========================================
Hits 18889 18889
Misses 3958 3958
Partials 482 482
|
@ghoshbishakh Running "make ipynbexamples" from the /doc folder generates all the "valid_examples" as .ipynb files in the folder "ipython_notebooks". The notebooks aren't executed though and all that this script does is convert the .py files in the "examples" directory to Ipython notebooks. This is pertaining to #720 |
@sahmed95 So we have to include the .ipynb files corresponding to each example it in the documentation somehow? |
So I wrote the script such that running This is the code : 0af58b5 |
I guess, the target is to build the ipython notebooks as one runs Currently ipython notebooks are converted by running |
Okey.. understood. I will start working on it. |
Thanks for taking this up. |
@Garyfallidis @jchoude In Scikit image and Django website the docs are listed according to release versions and there is one version called "dev". |
Yes I think that would be the bvest. However, I would default to showing the doc for te latest release as the default, since that is what most users will install. |
Hi @ghoshbishakh this is still set as WIP. What's the status? |
@jchoude It is actually complete. May be we can merge it and make separate PRs later for bug fixes? |
@Garyfallidis can this be merged? If further changes are required in future then I will make separate PRs. |
|
||
# paths | ||
docs_repo_path = "_build/docs_repo" | ||
docs_repo_url = "git@github.com:ghoshbishakh/dipy_web.git" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably point to nipy/dipy_web.git
Except for my last comment, for me this is +1 |
upload_docs.py script builds documentation for the current version and uploads it to gh-pages branche of the dipy_web repository
226a101
to
50507d3
Compare
@jchoude I have changed the repository url |
1 similar comment
Seems good to me. @ghoshbishakh Thanks. @arokem @Garyfallidis anyone wants to have a quick look? Else I'll merge by the end of the week. |
@ghoshbishakh Two things
|
@jchoude I have rebased it on master. And added some error handeling. |
1 similar comment
This looks good. Thanks for addressing the comments! |
Add documentation uploading script
upload_docs.py script builds documentation for the current version and uploads it to gh-pages branche of the dipy_web repository