BF::Fix inspect.getargspec deprecation warning in Python 3 #1413
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1413 +/- ##
==========================================
+ Coverage 86.81% 86.82% +0.01%
==========================================
Files 243 243
Lines 30215 30210 -5
Branches 3250 3250
==========================================
- Hits 26231 26230 -1
+ Misses 3244 3241 -3
+ Partials 740 739 -1
Continue to review full report at Codecov.
|
|
Awesome @naveenkumarmarri ! Thanks. Fixes #1327. |
There was a problem hiding this comment.
Thanks for doing this @naveenkumarmarri !
Even if I requested one change, it looks good.
Thanks !
dipy/workflows/multi_io.py
Outdated
| spargs.remove('self') | ||
| defaults = specs.defaults | ||
| if sys.version_info[0] >= 3: | ||
| sig_object = inspect.signature(fnc) |
There was a problem hiding this comment.
why you do not use get_args_default in dipy/workflows/base.py
I think it will avoid to duplicate the code
naveenkumarmarri
force-pushed
the
inspect_bug_fix
branch
from
6495575
to
0b8c3c3
Compare
|
@skoudoro made changes as per your feedback |
dipy/workflows/multi_io.py
Outdated
| @@ -1,11 +1,12 @@ | |||
| import inspect | |||
| import numpy as np | |||
| import os | |||
| import sys | |||
There was a problem hiding this comment.
Unused import sys. Can you remove it ?
|
Thanks @naveenkumarmarri, any other requests @jhlegarreta? If not, I merge it tomorrow |
|
Not on my side. Thanks for asking. Warnings have disappeared, so this is ready for merge. Thanks both @naveenkumarmarri and @skoudoro ! If the issue is not closed automatically (I think the |
|
@naveenkumarmarri, can you rebase please? Thank you |
naveenkumarmarri
force-pushed
the
inspect_bug_fix
branch
from
53cc137
to
0e3764a
Compare
|
Thank you @naveenkumarmarri ! merging ! |
BF::Fix inspect.getargspec deprecation warning in Python 3
for issue #1327