New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Examples #1584
Added Examples #1584
Conversation
Hello @karandeepSJ, Thank you for updating ! Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on August 12, 2018 at 15:09 Hours UTC |
I'm not sure we want a second UI example. I think I'd prefer to clean up the existing example and add these to it. By clean up, I mean:
Something like this |
Codecov Report
@@ Coverage Diff @@
## master #1584 +/- ##
==========================================
+ Coverage 87.33% 87.34% +0.01%
==========================================
Files 246 246
Lines 32177 32265 +88
Branches 3495 3504 +9
==========================================
+ Hits 28102 28183 +81
- Misses 3242 3247 +5
- Partials 833 835 +2
Continue to review full report at Codecov.
|
Huge improvement over the previous mess! Ultimately we'll want this to replace viz_ui.py instead of adding a second file. We'll also want to edit the text so it provides a coherent tutorial for the user. |
f1e7de3
to
dd63aa2
Compare
I feel like this PR is ready to go. Any other comment? I will wait until tomorrow for merging it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @karandeepSJ, it is almost ready to be merged. Can you fix the small comment below.
Thank you
doc/examples/viz_ui.py
Outdated
|
||
First, a bunch of imports. | ||
|
||
""" | ||
import os |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you separate """
and import os
by an empty line.
We need it to render the documentation correctly
Thank you @karandeepSJ and @dmreagan. Merging! |
This PR adds examples for the new elements in viz.ui. Currently, this includes the examples for the merged elements. I will add more as the other PRs get merged.