MAINT: Drop support for Python 3.4 #1866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arokem
commented
Jun 20, 2019
.travis.yml
Outdated
| @@ -35,7 +34,7 @@ matrix: | |||
| env: | |||
| - DEPENDS="$DEPENDS scipy" | |||
| # To test minimum dependencies for Python 3.6: | |||
| - python: 3.4 | |||
| - python: 3.6 | |||
There was a problem hiding this comment.
I think that this was a typo, now fixed.
Codecov Report
@@ Coverage Diff @@
## master #1866 +/- ##
==========================================
+ Coverage 84.31% 84.33% +0.01%
==========================================
Files 117 117
Lines 14234 14252 +18
Branches 2251 2255 +4
==========================================
+ Hits 12001 12019 +18
Misses 1716 1716
Partials 517 517
|
|
Looks like this one is now passing and ready for review. |
skoudoro
reviewed
Jun 21, 2019
| env: | ||
| # Check these values against requirements.txt and dipy/info.py | ||
| - DEPENDS="cython==0.29 numpy==1.8.2 scipy==1.0 nibabel==2.4.0 h5py==2.4.0" | ||
| - DEPENDS="cython==0.29 numpy==1.9.0 scipy==1.0 nibabel==2.4.0 h5py==2.4.0" |
There was a problem hiding this comment.
Finally, I have one comment: why do you update this Numpy version ? If we really need to update it, can you do it for requirements.txt and dipy/info.py
There was a problem hiding this comment.
Because there is no wheel for python 3.5/numpy 1.8.2.
|
Thank you @arokem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1865