Add a warning on attempted import. #1977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @arokem, Thank you for updating ! Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated at 2019-10-16 17:52:34 UTC |
|
Any chance to have a test for this PR @arokem? |
Codecov Report
@@ Coverage Diff @@
## master #1977 +/- ##
==========================================
+ Coverage 84.09% 84.09% +<.01%
==========================================
Files 118 118
Lines 15018 15020 +2
Branches 2372 2372
==========================================
+ Hits 12629 12631 +2
Misses 1829 1829
Partials 560 560
|
|
Sorry - yes - I have this for now. But it seems to be failing... I don't understand why the warning is not being captured by catch_warnings. It's definitely being emitted! |
|
Thanks! Maybe because of a warning filter rules. I do not know which one but I got this problem once. |
[fix] update test for import error
|
Thank you for this @arokem! Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would this properly address #1976 ?
The cryptic error is still raised, but is preceded by a warning:
