Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] renamed Direct Streamline Normalization tutorial title #2212

Merged
merged 1 commit into from Sep 8, 2020

Conversation

areeshatariq
Copy link
Contributor

fixes #2114

@codecov
Copy link

codecov bot commented Sep 7, 2020

Codecov Report

Merging #2212 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2212      +/-   ##
==========================================
- Coverage   91.38%   91.37%   -0.01%     
==========================================
  Files         251      251              
  Lines       32516    32517       +1     
  Branches     3424     3424              
==========================================
  Hits        29714    29714              
  Misses       2057     2057              
- Partials      745      746       +1     
Impacted Files Coverage Δ
dipy/segment/tests/test_bundles.py 89.52% <0.00%> (-0.96%) ⬇️
dipy/viz/app.py 77.47% <0.00%> (+0.05%) ⬆️

@arokem
Copy link
Contributor

arokem commented Sep 7, 2020

Thanks for doing this. I offered an alternative wording, which I think works better here.

@arokem arokem merged commit 3a97aba into dipy:master Sep 8, 2020
@arokem
Copy link
Contributor

arokem commented Sep 8, 2020

🎉 congratulations @areeshatariq on your first merged contribution to DIPY!

@skoudoro
Copy link
Member

skoudoro commented Sep 8, 2020

🥳 🎉 👍

@skoudoro skoudoro modified the milestones: 1.3, 1.2 Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tutorial title in Streamline-based registration section is misleading
3 participants