ENH: Miscellaneous cleanup #2522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jhlegarreta
commented
Feb 18, 2022
•
jhlegarreta
commented
- DOC: Document missing parameters
- ENH: Remove unused import statement
- ENH: Remove unused local variables
- ENH: Remove unused method parameter
- STYLE: Remove redundant parentheses
- STYLE: Simplify chained comparisons
- DOC: Fix spelling mistakes
|
By no means this intends to be exhaustive: I just visited these files and my editor was prompting me with these things. |
skoudoro
reviewed
Feb 18, 2022
There was a problem hiding this comment.
Thanks @jhlegarreta, always good to have some code cleaning PR.
See my comments below. I think the tests are failing because of that. You remove the wrong one.
Document missing parameters and remove documentation of parameters that are no longer present.
Remove unused import statement.
jhlegarreta
force-pushed
the
MiscCleanUp
branch
2 times, most recently
from
0728c08
to
e119d5d
Compare
Remove unused local variables. Fixes warning: ``` Local variable 'sqrtC' value is not used ``` And similar other warnings.
Remove unused method parameter. Fixes warning: ``` Parameter 'dtype' value is not used ```
Remove redundant parentheses.
jhlegarreta
force-pushed
the
MiscCleanUp
branch
from
e119d5d
to
b29ce1d
Compare
arokem
reviewed
Feb 18, 2022
Codecov Report
@@ Coverage Diff @@
## master #2522 +/- ##
==========================================
- Coverage 84.85% 84.85% -0.01%
==========================================
Files 126 126
Lines 17151 17148 -3
Branches 2914 2914
==========================================
- Hits 14554 14551 -3
Misses 1926 1926
Partials 671 671
|
Simplify chained comparisons by splitting them into two statements.
Fix spelling mistakes in docstrings/comments.
jhlegarreta
force-pushed
the
MiscCleanUp
branch
from
b29ce1d
to
ae320ae
Compare
|
All concerns have been fixed, thank you @arokem for the review, and thanks @jhlegarreta for the code cleaning. merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.