New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NF - Added cython utility functions #2716
Conversation
Thanks @gabknight, For the test, you can create a Inside the tests, check if np.dot is slower than your function and obtain the same result |
ok, thanks. I needed to change the function declaration from cdef to cpdef for the tests. Cross is 25x faster, dot is 1.5x on the length-3 vectors. There will more gain when doing the tracking in c. |
e375892
to
c7a8a31
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2716 +/- ##
=======================================
Coverage 83.83% 83.83%
=======================================
Files 131 131
Lines 18292 18293 +1
Branches 2979 2980 +1
=======================================
+ Hits 15335 15336 +1
Misses 2220 2220
Partials 737 737
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just waiting for the CI to finish and this PR is ready to be merged.
Thank you @gabknight
SMALL NOTEWe need a system to allow pytest to run test on |
Utility functions for PTT tracking PR #2596.
Is there a good way to add unit tests on these?