Fixed typos + autopep8

[samuelstjean]

Found some small typos when viewing docs, so I corrected them and ran an autopep8 on the file as well.

[arokem]

You would think, but it doesn't seem so: http://en.wikipedia.org/wiki/Rodrigues'_rotation_formula

[arokem]

Which also suggests that we should change it everywhere else...

[samuelstjean]

Though there was one typo, not the opposite. The problem is that correcting it will also change the function name, breaking any custom script function using it. We can change it seems seldom used I guess.

[arokem]

This all looks good to me, except for the Rodrigues/Rodriguez spelling
debacle. Also, Travis seems to be having some issues, so if you make
another commit, maybe he will start behaving.

On Mon, Nov 25, 2013 at 1:09 AM, Samuel St-Jean notifications@github.comwrote:

Found some small typos when viewing docs, so I corrected them and ran an

autopep8 on the file as well.

You can merge this Pull Request by running

git pull https://github.com/samuelstjean/dipy typos

Or view, comment on, or merge it at:

#273
Commit Summary

• Fixed typos + autopep8

File Changes

• M dipy/core/geometry.pyhttps://github.com/Fixed typos + autopep8 #273/files#diff-0(157)

Patch Links:

• https://github.com/nipy/dipy/pull/273.patch
• https://github.com/nipy/dipy/pull/273.diff

[MrBago]

This is a little off topic, but how do you guys feel about thinning this module? The following functions are not tested in dipy.core.test.test_geometry and are not called at all during any other dipy tests:

compose_matrix
decompose_matrix
euler_matrix
lambert_equal_area_projection_cart
normalized_vector
rodriguez_axis_rotation

The following functions are tested in dipy.core.tests.test_geometry, but are not called by other dipy test:

cart_distance
circumradius
lambert_equal_area_projection_polar
nearest_pos_semi_def
sphere_distance
vector_cosine

[samuelstjean]

I also grepped the whole dipy tree and the function doesn't seems to be imported anywhere. So it will only break user's script, which is bad if anyone was using that.

[Garyfallidis]

@samuelstjean, @MrBago I am going to have a PR soon (but after the release) which will use some of these functions. I would suggest to clean up these functions after that. @samuelstjean thank you for the pep8 update. This was old code from the time were we were not forcing pep8. Thx!