WIP - FVTK refactor/cleanup

[stefanv]

No description provided.

[Garyfallidis]

Hi Stefan, all this is interesting and it gave me some ideas on how to make 3D visualization better in Dipy. The problem is I can only start looking at this after the release and most likely after Christmas. But we will get there at the end. Thank you for looking at this!

[arokem]

+1 on Eleftherios' comment here. These are good, but I don't think this
should go into 0.7.

BTW - what is the status of #279 ?

That one is definitely intended for this release, correct?

On Tue, Dec 17, 2013 at 11:03 AM, Eleftherios Garyfallidis <
notifications@github.com> wrote:

Hi Stefan, all this is interesting and it gave me some ideas on how to
make 3D visualization better in Dipy. The problem is I can only start
looking at this after the release and most likely after Christmas. But we
will get there at the end. Thank you for looking at this!

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/286#issuecomment-30779921
.

[Garyfallidis]

Yes, of course it is intended for the release. Please start commenting on it. I have removed the WIP flag.

[stefanv]

There are several places marked with XXX where I did not have sufficient
knowledge to update the docs. Would you please comment on these?

[Garyfallidis]

Correct. This is the focal point of the camera.

[Garyfallidis]

Hello, where are we with this? Is there something being expected on my side?

[arokem]

Yes - you were supposed to make a PR against this one, with clarifications in the documentation. For example, a bit of explanation about the VTK camera parameters.

[Garyfallidis]

I have written the rest of clarifications as comments here. I prefer working on the camera on a different PR. Is that okay?

[stefanv]

Sorry, I've been traveling for the past two weeks, but can get started this
week.

[samuelstjean]

Does the refactoring works with vtk6? I tried an example for fun, and fvtk.show works while fvtk.record doesn't, as a heads-up. I think Elef did some work on vtk6 support, there still seems to be some functions missing the vtk5/vtk6 logic though.

[Garyfallidis]

@stefanv is it okay if I close this? We are going to merge #587 today.

[stefanv]

Yes, that's fine, thank you for asking.