ENH: Implement NDC from Yeh2019

[mattcieslak]

Adds a function to address #3154.

What would you recommend to add for a test?

[arokem]

Looks good! Regarding testing, I'd suggest testing that correlation between a signal and itself is 1, maybe with different sets of b-vectors and b-values. Maybe also that this correlation doesn't change if one of the signals is scaled. For smoke testing, worth testing with different gradient schemes, with and without b=0, for example.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.40%. Comparing base (f765aa0) to head (f23a605).
Report is 4 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3156      +/-   ##
==========================================
+ Coverage   82.17%   82.40%   +0.23%     
==========================================
  Files         150      151       +1     
  Lines       21271    21306      +35     
  Branches     3413     3417       +4     
==========================================
+ Hits        17479    17558      +79     
+ Misses       2950     2908      -42     
+ Partials      842      840       -2     

Files	Coverage Δ
dipy/stats/qc.py	100.00% <100.00%> (ø)

... and 8 files with indirect coverage changes

[skoudoro]

Also there is no automatic module discovery.

So, this new file needs to be added in meson.build.

Thank you for this. Personally, I need to read the paper

[pep8speaks]

Hello @mattcieslak, Thank you for updating !

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated at 2024-04-01 13:34:08 UTC

[mattcieslak]

should be good for review!

[arokem]

LGTM!

[ShreyasFadnavis]

Looks great! Thanks for this @mattcieslak ! -- Not sure if denoise is the right module for it though?

I don't want people to miss this utility, just because they did not look in the right place.

Alternative modules could be stats?

[skoudoro]

Is there any additional comment @arokem @ShreyasFadnavis or @araikes??

I think this PR is ready to get in.

[skoudoro]

Thank you for this @mattcieslak !