Add the mode param for border management. #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| mode : string ('constant', 'nearest', 'reflect' or 'wrap') | ||
| Points outside the boundaries of the input are filled according | ||
| to the given mode. | ||
|
|
There was a problem hiding this comment.
If you add mode, I guess one should also add cval.
|
Can you also add some tests to check that the new parameter(s) get applied? |
|
No, I will write the test for this function. This is some of my very old cold for which I didn't create a test. This is my responsibility. Thank you @matthieudumont for the fix. |
|
I will add also an issue so that I don't forget about this. Thx! |
Garyfallidis
added a commit
that referenced
this pull request
May 26, 2014
Add the mode param for border management.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the possibility to specify the mode parameter to scipy's affine_transform to have more control over border management.
The only real code change is the addition of the mode param to the resample method and the passing of this mode to the two affine_transform calls. All the other changes are some pep8ifications while I was there.