ENH: Implement masking for the new TensorModel implementation. #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # If a mask is provided, we will use it to access the data | ||
| if mask is not None: | ||
| # Make sure it's boolean, so that it can be used to mask | ||
| mask = np.array(mask, dtype=bool) |
There was a problem hiding this comment.
We should use copy=False here to prevent copying if we don't need to.
There was a problem hiding this comment.
yep. good call.
On Wed, Dec 5, 2012 at 11:34 AM, MrBago notifications@github.com wrote:
In dipy/reconst/dti.py:
"""
dti_params = self.fit_method(self.design_matrix, data,- _self.args, *_self.kwargs)
return TensorFit(self, dti_params)# If a mask is provided, we will use it to access the dataif mask is not None:# Make sure it's boolean, so that it can be used to maskmask = np.array(mask, dtype=bool)We should use copy=False here to prevent copying if we don't need to.
—
Reply to this email directly or view it on GitHubhttps://github.com//pull/96/files#r2325597.
|
Cool! |
Garyfallidis
added a commit
that referenced
this pull request
Dec 6, 2012
ENH: Implement masking for the new TensorModel implementation.
| @@ -62,12 +62,26 @@ def fit(self, data): | |||
| data : array | |||
| The measured signal from one voxel. | |||
|
|
|||
| mask : array | |||
| A boolean array used to mark the coordinates in the data that | |||
| should be analyzed that has the shape data.shape[-1] | |||
|
An interesting aside, you can now fit the tensormodel in two different ways:
Cool! We should document these two approaches and do some timing comparisons! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.