Development2 #13
Merged
Development2 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ghoshbishakh do you plan on adding anything, or I can go ahead and check it? |
| @@ -20,3 +20,6 @@ | |||
| url(r'^admin/', admin.site.urls), | |||
| url(r'^', include('website.urls')), | |||
| ] | |||
|
|
|||
| handler404 = 'website.views.custom404' | |||
There was a problem hiding this comment.
For my info, those do not seem to be added to url_patterns. Are those names (handler404 and 500) reserved words?
There was a problem hiding this comment.
Yes handler404 and handler500 are reserved words. Django performs some kind of magic with them and renders the views assigned to them in case of 404 or 500.
|
Overall, seems good. |
|
@jchoude So should I push future changes in a different PR? |
This generates a list of tutorials with descriptions and thumbnails from the documentation and displays them.
|
@Garyfallidis @jchoude I am not pushing any more commits in this PR. So this may be reviewed now. |
| Channel ID of the youtube channel for which the videos will | ||
| be retrieved. | ||
|
|
||
| count: int |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.