GitHub visualization #15
Conversation
ghoshbishakh
force-pushed
the
githubVisualization
branch
from
7a060f9
to
544d752
Compare
|
Hey @ghoshbishakh I'm going through this... Just to make sure, is it normal that the heroku version currently doesn't show anything in the graphs? |
|
|
||
|
|
||
| class GithubStatFetcher: | ||
| """A GitHub statistics fetcher for github repositories |
|
@jchoude looks like heroku does not fetch the data correctly when it wakes up. Can you try hard reloading the page now? |
| weeks : list | ||
| List of weeks of contributions. Example: | ||
| [ | ||
| {'w': 1254009600, 'a': 5, 'c': 2, 'd': 9}, |
There was a problem hiding this comment.
I'm not really sure of the way this parameter needs to be sent. I guess this comes from the Github API? If so, please refr to that so the the user can go to the correct documentation.
There was a problem hiding this comment.
Yes. That is why I have described it as a helper function. I am not sure how to describe these otherwise.
There was a problem hiding this comment.
Just say that it parses the list format returned from the Github API. You might also want to make it "private" so that users know that it's not that useful to them.
|
Yes it fetched correctly now. |
| weekly_contributions["changes"] = [] | ||
| lines = 0 | ||
| for changes in r1_json: | ||
| changeList = [] |
There was a problem hiding this comment.
Same thing here for the "_" in the name.
|
Seems all good from my point of view. Will wait until your fixes and answers. |
|
|
||
| cumulative_contributors = self.get_cumulative_contributors(r_json) | ||
| contributor_stats[ | ||
| "cumulative_contributors"] = cumulative_contributors |
There was a problem hiding this comment.
@jchoude here is the cumulative_contributors actually. Do you mean something different?
There was a problem hiding this comment.
Ok, I saw your reply, but it doesn't show up in github. Anyway, makes sense.
2016-08-15 9:16 GMT-04:00 Bishakh Ghosh notifications@github.com:
In github_visualization/github_stats.py
#15 (comment):
contributor_dict["total_commits"] = contributor["total"]grand_total_commits += contributor["total"]
total_additions, total_deletions = self.get_total_contributions(contributor["weeks"])
contributor_dict["total_additions"] = total_additionscontributor_dict["total_deletions"] = total_deletionscontributor_dict["weekly_commits"] = contributor["weeks"]contributor_stats["contributors"].insert(0, contributor_dict)
contributor_stats["total_commits"] = grand_total_commits
cumulative_contributors = self.get_cumulative_contributors(r_json)contributor_stats["cumulative_contributors"] = cumulative_contributors@jchoude https://github.com/jchoude here is the cumulative_contributors
actually. Do you mean something different?—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nipy/dipy_web/pull/15/files/544d752148f59db2105e126695f7f6f2b9c43455#r74759230,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACDSeBtsdgnwCuSyDDw6Lxmy6v7ydHcCks5qgGaYgaJpZM4JeWOf
.
The API endpoint https://api.github.com/repos/nipy/dipy/stats/contributors returns the list of contributors and their weekly contributions. But sometimes in cases if a user has renamed or deleted his/her GitHub profile then it might return "author":null for an intermediate time period after which it is completely removed from the list. This patch handles the exception by ignoring the "author":null entry and counting rest of the contributors fixes dipy#21
No description provided.