Hits rerun #78
Merged
Hits rerun #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still seem to be getting the failed tests when building on an aws instance. I'll look further into this |
|
LGTM. But maybe we should wait until Peter finishes looking into the AWS build? |
jbkalmbach
approved these changes
Oct 17, 2018
|
I'm not 100% sure yet but this issue reminds me of the same one we had once installing on @smotherh's laptop where it would build just fine but a mismatching python version (I think?) caused all gpu dependent functions to fail. I'll see if I can write a test that will detect this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug where PYTHONPATH was exported in the wrong order, causing the shell to be unable to find kbmod.