Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to 3.10, 3.11, 3.12 python #738

Closed
wants to merge 1 commit into from
Closed

update to 3.10, 3.11, 3.12 python #738

wants to merge 1 commit into from

Conversation

mschwamb
Copy link
Collaborator

@mschwamb mschwamb commented Dec 1, 2023

update to 3.10+ python for tests and requirements

Fixes #734 (possibly)

Describe your changes.

Review Checklist for Source Code Changes

  • Does pip install still work?
  • Have you written a unit test for any new functions?
  • Do all the units tests run successfully?
  • Does Sorcha run successfully on a test set of input files/databases?
  • Have you used black on the files you have updated to confirm python programming style guide enforcement?

update to 3.10+ python for tests and requirements
@mschwamb
Copy link
Collaborator Author

mschwamb commented Dec 1, 2023

numba will support python 3.12 in a few days (see here). if this fixes the unit tests then I think we should move away from 3.9

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8f0c714) 65.31% compared to head (defb042) 65.31%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #738   +/-   ##
=======================================
  Coverage   65.31%   65.31%           
=======================================
  Files          67       67           
  Lines        3451     3451           
=======================================
  Hits         2254     2254           
  Misses       1197     1197           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mschwamb
Copy link
Collaborator Author

Ticket tracking numba progress on 3.12 release numba/numba#9197

@mschwamb
Copy link
Collaborator Author

mschwamb commented Feb 2, 2024

No longer needed as we are using mac ARM runners

@mschwamb mschwamb closed this Feb 2, 2024
@mschwamb mschwamb deleted the unit_tests_fix branch February 2, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit tests failing in github CI
1 participant