feat: add oz prefix name #283
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10009263398Details
💛 - Coveralls |
diranged
reviewed
Jul 19, 2024
| @@ -108,7 +108,7 @@ func init() { | |||
| createExecAccessRequestCmd.Flags(). | |||
| StringVarP(&waitTime, "wait", "w", "1m", "Duration to wait for the access request to be fully ready. Valid time units are: ns, us, ms, s, m, h.") | |||
| createExecAccessRequestCmd.Flags(). | |||
| StringVarP(&requestNamePrefix, "request-name", "N", usernameEnv, "Prefix name to use when creating the `ExecAccessRequest` objects.") | |||
| StringVarP(&requestNamePrefix, "request-name", "N", fmt.Sprintf("oz-%s", usernameEnv), "Prefix name to use when creating the `ExecAccessRequest` objects.") | |||
There was a problem hiding this comment.
- Labels should be used to isolate/filter for pods... not names.
- This should be a configurable property that is optional. The question is, shoudl it be a controller setting or an AccessTemplate setting?
Repository owner
deleted a comment from
gorangasic
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ozprefix as the defaultrequest-name. This would help allow us to filter oz pods from alerts.