Fix bug in dce_internalClosedir #133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the function dce_internalClosedir, there is a memory assignament (ds->fd = saveFd) that have been already freed by a call to closedir some lines above (ret = closedir (dirp)). The directory stream descriptor dirp is not available after this call causing a SEGFAULT.
|
pushed in commit 042d38a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I'm woriking on porting FRRouting to dce. I've fixed a couple of bugs while working on it and I'd like to merge them.
In the function dce_internalClosedir, there is a memory assignament (ds->fd = saveFd) that have been already freed by a call to closedir some lines above (ret = closedir (dirp)). The directory stream descriptor dirp is not available after this call causing a SEGFAULT.