This repository has been archived by the owner on Jan 6, 2023. It is now read-only.
Check version variable for MariaDB as well as version_comment #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @assmith! All these PRs are so helpful! We'll have @wellingguzman review them tomorrow morning. Really appreciate the contributions. 😄 |
wellingguzman
approved these changes
Dec 5, 2018
There was a problem hiding this comment.
Thank you @assmith, I updated the code a bit, and I fixed a initialization typo.
samvasko
pushed a commit
to samvasko/api
that referenced
this pull request
Nov 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On AWS at least, version_comment contains the rather unhelpful value "Source distribution". version however contains "10.3.8-MariaDB-log". This PR is for a suggested widening of the variable search to include version when testing for MariaDB.