How to extend the exceptions error object?

[ghost]

I tried to create a new class to inherit BaseException, but that didn't work, it still uses INTERNAL_SERVER_ERROR

Not Working

Working

I tried to shift to a new way of inheritance

it works!
I don't understand why this is

[azrikahar]

I believe it's due to the instanceof BaseException in your first example will in fact be false, rather than true. When you shift the class declaration inside the export function, it then properly registers as an instance of the "same" BaseException.

I'm not 100% sure on the reasoning myself, but it could somehow be related to https://github.com/Microsoft/TypeScript/wiki/Breaking-Changes#extending-built-ins-like-error-array-and-map-may-no-longer-work? cc @nickrum as I could be very wrong and way off here.

In your first example, if you were to use require instead of import, it should work (at least it did for me):

- import { BaseException } from "@directus/shared/exceptions";
+ const { BaseException } = require("@directus/shared/exceptions");

[ghost]

yes you are right "instanceof BaseException" always return false

i used "const {BaseException} = require("@directus/shared/exceptions");"

The BaseException exported from @directus/shared/exceptions is not the same as the BaseException inside the hooks

[azrikahar]

Thanks for confirming! It is rather odd, and frankly I'm not 100% what's happening here either (aside from the link I shared earlier, as well as this link which seems to alude to compilation target being a potential culprit: https://www.dannyguo.com/blog/how-to-fix-instanceof-not-working-for-custom-errors-in-typescript/).

[nickrum]

Not exactly sure what's happening here either, but it could be that the extension and the API use different versions of the @directus/shared package.

[ghost]

I had to use the initExceptions function to save the BaseException returned inside the hook