Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drawers open behind modals #10892

Closed
3 tasks done
dimitrov-adrian opened this issue Jan 6, 2022 · 5 comments · Fixed by #11642
Closed
3 tasks done

Drawers open behind modals #10892

dimitrov-adrian opened this issue Jan 6, 2022 · 5 comments · Fixed by #11642
Labels

Comments

@dimitrov-adrian
Copy link
Contributor

dimitrov-adrian commented Jan 6, 2022

Preflight Checklist

Describe the Bug

Items drawer appears behind the v-modal in upload dialog.

To Reproduce

Create text field with markdown interface, allow image tool. With the new field add image and pick "Choose from library"

Untitled.mov

Errors Shown

No response

What version of Directus are you using?

9.4.2

What version of Node.js are you using?

16

What database are you using?

mysql5.7

What browser are you using?

Chrome

What operating system are you using?

macOS Big sur

How are you deploying Directus?

locally

@ijpatricio
Copy link
Contributor

I came to add this Issue, and noticed is already here.
Can confirm.
I started using with docker, but will try to install in local, so I can try to solve this.

@log4shell
Copy link

I can confirm the same issue on my local instance of Directus 9.4.2. As a manual work-around in the browser, you can right-click and "inspect" to file upload dialog and then delete the <div> block that holds this dialog:

image

After it's removed, you can select files from the file library that was blocked behind the dialog.

@rijkvanzanten
Copy link
Member

This is caused by my update to the drawer handling here: 6e439db that wrongly assumes that dialogs should always be above drawers

@ijpatricio
Copy link
Contributor

I should have had time to look into it, but time is very tight here.
I'll try my best

@rijkvanzanten
Copy link
Member

No worries @ijpatricio, I know how that goes.. 👀

The reason I split up the two "stacks" is that I relied on CSS's nth-of-type operator to do the stacked drawer effect. We might be able to revert that split by using a different tag (div vs.. span? is <dialog> supported enough yet?) as nth-of-type only checks against used tag

@rijkvanzanten rijkvanzanten changed the title Files library appears behind upload dialog Drawers open behind modals Jan 25, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants