Align readMany and readByQuery in SDK

[br41nslug]

Preflight Checklist

• I have completed all Troubleshooting Steps.
• I'm on the latest version of Directus.
• There's no other issue that already describes my problem.

Describe the Bug

The current javascript sdk documentation still refers to the readByQuery function on the ItemsService which judging from the code was merged into the readMany function.

[rijkvanzanten]

The real issue here is that the SDK isn't aligned with the internal services from Directus itself at the moment. We should split up readMany and readByQuery in the JS SDK as well, so it aligns with the ItemService's readMany and readByQuery calls

[br41nslug]

I fully agree that thats the underlying issue. but the immediate issue here is that the docs and code are out of sync.

[rijkvanzanten]

@br41nslug Wanna shoot a quick PR to those docs? 🙂

[br41nslug]

Damnit i hate writing docs 🤣 but sure i'll give it a go

[joselcvarela]

The real issue here is that the SDK isn't aligned with the internal services from Directus itself at the moment. We should split up readMany and readByQuery in the JS SDK as well, so it aligns with the ItemService's readMany and readByQuery calls

I am not sure if this is the right approach.
SDK is just a thin wrapper around the REST API. Although ItemsService has a readMany which can read multiple items by primary keys, the same does not happen on the REST API, because we can only pass a single primary key on GET.
If we would implement readMany on SDK, it was simply a filter: { [primaryKey]: { _in: [keys] } } on current readMany, so I am not sure if makes sense to create such method 🤔

[rijkvanzanten]

If we would implement readMany on SDK, it was simply a filter: { [primaryKey]: { _in: [keys] } } on current readMany, so I am not sure if makes sense to create such method

To me, that actually makes sense. If you have people that are writing both extensions, and use the SDK on their own projects, this consistent naming system with different type signatures is very confusing!