Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to revert the value by typing for an edited but unsaved O2M item #13543

Closed
koksikus opened this issue May 25, 2022 · 8 comments
Closed
Assignees
Labels

Comments

@koksikus
Copy link

Describe the Bug

In an O2M field, when I want to change the text in the field (Input) of item in other collection, the letter in the second place I "shift with i" sends me to the end of the text ...

To Reproduce

Click on the O2M to edit field then confirm and not closing the main record but opening it once more, try to enter in the second place I "shift with i" will send you to the end of the text..

Errors Shown

No response

What version of Directus are you using?

9.11.1

What version of Node.js are you using?

16.15

What database are you using?

Sql server 2017

What browser are you using?

Edge

How are you deploying Directus?

locally

@azrikahar
Copy link
Contributor

I can't seem to reproduce this, but just so we can be on the same page here, would you mind sharing a quick clip on this particular interaction?

In the spirit of cases such as #13495 which turned out to be user's machine-dependent, it would also be helpful if you can try it with another device and/or browser as well as an attempt to rule out more possibilities here.

@koksikus
Copy link
Author

I did tests on different computers and browsers and databases, the problem is the same and I will show it in the video (from my local version of Directus for testing)

Itemy.mp4

Where the cursor jumps to the end, I try to press "I"

@koksikus
Copy link
Author

I noticed one more thing that after the update, the conditions do not work properly ...

Itemy.mp4

I included the second case in # 13451

@azrikahar
Copy link
Contributor

Where the cursor jumps to the end, I try to press "I"

Thanks for the video! I believe the actual issue here is when we are making the value become the original value, there's a weird "reset" behavior which causes the cursor go to the end of the input. Will update this issue's title to reflect this clearer.

chrome_Hv5DU0xQAS.mp4

I noticed one more thing that after the update, the conditions do not work properly

Answered your comment in #13451 (comment), but mentioning it here again just to link them together: This should be fixed in #13563.

@azrikahar azrikahar changed the title Letter in second place Unable to revert the value of an edited but unsaved O2M item May 26, 2022
@azrikahar azrikahar changed the title Unable to revert the value of an edited but unsaved O2M item Unable to revert the value by typing for an edited but unsaved O2M item May 26, 2022
@koksikus
Copy link
Author

I have the same thing. It seems to me that it all depends where you remove the letter ... The same is true of searching in a table that has a relationship. When I enter the numbers, they disappear by themselves, and when I try to delete, they reappear and I have to delete it myself - it looks like something in the background is refreshing ...

@br41nslug
Copy link
Member

Running into the same issue on M2M junction tables where explicitly typing/selecting the default value for the field will unset it back to the initial value.
firefox_wDIPszAXdt

@rijkvanzanten
Copy link
Member

Linear: ENG-253

@Nitwel Nitwel self-assigned this Feb 8, 2023
@Nitwel
Copy link
Member

Nitwel commented Mar 31, 2023

I do remember fixing this but I'm not able to find the PR that fixed it and it seems to work at the moment. I will close this because of that but please reopen it if I'm mistaken and this issue still exists!

@Nitwel Nitwel closed this as completed Mar 31, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants