Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Webhooks #15553

Closed
Nitwel opened this issue Sep 13, 2022 · 8 comments · Fixed by #21808
Closed

Remove Webhooks #15553

Nitwel opened this issue Sep 13, 2022 · 8 comments · Fixed by #21808
Assignees

Comments

@Nitwel
Copy link
Member

Nitwel commented Sep 13, 2022

We should remove Webhooks from the app & api in v10 as they are currently implemented twice with flows.

@Nitwel
Copy link
Member Author

Nitwel commented Sep 13, 2022

This issue can also be fixed when removing Webhooks. #11679

@piotr-cz
Copy link
Contributor

piotr-cz commented Dec 3, 2022

Is it possible to modify the response with flows?
From reading the Custom Operations docs it doesn't look like it is, unlike when using hooks.

I'm particularly interested in adding custom header to all responses.

@rijkvanzanten
Copy link
Member

@piotr-cz This issue is referring to Webhooks, not the Hooks extensions 👍🏻

@piotr-cz
Copy link
Contributor

piotr-cz commented Dec 3, 2022

@rijkvanzanten Great, thank you!

@rijkvanzanten
Copy link
Member

Linear: ENG-190

@Attacler
Copy link

@Nitwel might i ask why?
For my POV webhooks are to let another party notice that something has been changed.
Flows are for internal automation (might also add a webhook call to another party) but would require a little more extra work.

I am in favor of this but some people might already be using them because they are easier to setup in comparison with a flow.

@rijkvanzanten
Copy link
Member

@Attacler Flows does everything webhooks does and more, the amount of configuration is only marginally different, so there isn't really a point for us to try to maintain two different bits of logic that achieve the same goal 🙂

@alexchopin
Copy link

This feature is deprecated so let's do a soft remove by checking if the project have webhooks:

  • If not? Disable the webhooks module.
  • If yes? Display a banner that link to the flow/webhooks documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants