Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate meta in favor of aggregation #15665

Open
azrikahar opened this issue Sep 20, 2022 · 4 comments
Open

Deprecate meta in favor of aggregation #15665

azrikahar opened this issue Sep 20, 2022 · 4 comments

Comments

@azrikahar
Copy link
Contributor

Deprecate metadata from the api (and existing usages in the app) in v10 in favor of aggregation such as aggregate[count]. Originally planned back in #5880.

@benosman
Copy link

benosman commented Sep 23, 2022

Would this lose the ability to get both the collection items and the filter_count in one api request?

I know on the DB side metadata involves an extra query, but it is handy when using the REST API to save a roundtrip by getting the metadata in the same response.

Is there any way to do to this with aggregate[count]?

@rijkvanzanten
Copy link
Member

@benosman If we'd want to keep it REST "proper", doing one query per request is correct. GraphQL has the benefit of doing multiple queries per request. That being said, I'm down to figure out if there's a clean way we can allow both aggregating and regular data fetching simultaneously

@rijkvanzanten
Copy link
Member

Linear: ENG-185

@jaads
Copy link
Member

jaads commented Aug 14, 2023

the actual removal of the mata attribute in the API response is currently on hold.

we will first mark this as deprecated in the docs and do the actual breaking change later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🙅 Blocked
Development

Successfully merging a pull request may close this issue.

6 participants