Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add folder picker in image/file interface drawer #15968

Closed
rijkvanzanten opened this issue Oct 12, 2022 Discussed in #4999 · 7 comments · Fixed by #18320
Closed

Add folder picker in image/file interface drawer #15968

rijkvanzanten opened this issue Oct 12, 2022 Discussed in #4999 · 7 comments · Fixed by #18320

Comments

@rijkvanzanten
Copy link
Member

When using the image(s)/file(s) interfaces, the sidebar doesn't render the folder picker. We should render the file-library folder picker in the left sidebar of the drawer when the files are being selected.


Discussed in #4999

Originally posted by Meldiron April 12, 2021
If we add Image interface there are 3 options: from disk, from gallery, from URL

image

If we pick option from mgallery, we get list of all files uploaded to Directus that we can filter by name

image

My idea is, can we filter by folders? If I enter file library, there is the left panel to put files into folder in order to prevent mess

image

Having a folder selection instead of list of all files would be awesome ♥

@azrikahar azrikahar changed the title Use folders on image iterface Add folder picker in image/file interface drawer Oct 13, 2022
@azrikahar azrikahar self-assigned this Nov 17, 2022
@polmonroig
Copy link

Does anyone know what is the status of this issue?? This is very important for my Company, thank!

@rijkvanzanten
Copy link
Member Author

Linear: ENG-165

@rijkvanzanten
Copy link
Member Author

Does anyone know what is the status of this issue?? This is very important for my Company, thank!

Unfortunately, we can not provide estimates on features or fixes. As of now, the only way to get an accurate timeline or release date is to sponsor this task. We recognize that this may be an important feature/fix, but we are a small open-source organization with a lot to triage and complete. If you can't sponsor this ticket, then the next best thing is to increase its priority by giving it a 👍 . Or contribute a pull-request... after all, this is OSS!


This is an automated response.

@renet
Copy link

renet commented Jan 26, 2023

I think the approach depicted in #4999 (comment) is a bit more practical, as the file selection dialog (drawer) is pretty narrow and layout issues would occur, if there was a sidebar added to it (thumbnails per row would have to be reduced or get smaller). Showing the subfolders of the current folder on top of the files would contribute more to a "Windows Explorer" or "Finder" look and feel and improve UX a bit.

Additional features

  1. I think it would make sense to add a possibility to create a new file inside a specific folder within the file picker view. Creating new folders should be possible, as well then. Alternatively it would make sense to allow the user to select the folder (or create a new one) that a new file is being uploaded to, when drag'n'dropping/browsing a new file from the Image interface.
  2. I think showing the subfolders of the current folder on top of the files should also be added to the main File Library view.

Is this issue still open for changes / extended scope and can the additional features be added to it or do they require separate issues?

@rijkvanzanten
Copy link
Member Author

Showing the subfolders of the current folder on top of the files would contribute more to a "Windows Explorer" or "Finder" look and feel and improve UX a bit.

This is a way bigger effort though, as that's something that has to be supported for relationships in general for any of the layouts, which (while very useful) is going to increase the scope of this quite a bit. I personally think a good first step is to use the same navigation component you'd find on the file library in the drawer sidebar to at least unlock the functionality, with the intention of enhancing all layouts with the "m2o folder" support in the future :)

@renet
Copy link

renet commented Jan 31, 2023

Sure, that makes sense. How do you expect this to look like? Add the sidebar permanently visible to the left side of the "Select Item" overlay? Or making it "expandable" via a trigger button inside the overlay and let the sidebar / folder picker float on top of the thumbnails while opened? How's the process here, will features like this one be designed first, or should the developer code a first draft?

with the intention of enhancing all layouts with the "m2o folder" support in the future :)

Sounds good! :)

@rijkvanzanten
Copy link
Member Author

Sure, that makes sense. How do you expect this to look like? Add the sidebar permanently visible to the left side of the "Select Item" overlay? Or making it "expandable" via a trigger button inside the overlay and let the sidebar / folder picker float on top of the thumbnails while opened?

I think the first option makes the most sense for this! Lets start with the simple approach we know will work for everyone. We can always make it more complicated in the future 🙂

How's the process here, will features like this one be designed first, or should the developer code a first draft?

It depends! In this case, the improvement is known, relatively small in scope, and comprised of existing base-components, so no new design is required. For bigger new features etc, we should tackle the UX research and design before committing to code 👍🏻

@azrikahar azrikahar removed their assignment Apr 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants