Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No visual feedback if thumbnail cannot be generated (e.g. image file too big) #16440

Closed
fabianbeier opened this issue Nov 14, 2022 · 3 comments · Fixed by #21143
Closed

No visual feedback if thumbnail cannot be generated (e.g. image file too big) #16440

fabianbeier opened this issue Nov 14, 2022 · 3 comments · Fixed by #21143

Comments

@fabianbeier
Copy link

Describe the Bug

If an image is uploaded that is larger than the ASSETS_TRANSFORM_IMAGE_MAX_DIMENSION no thumbnail is generated in the app. If you access the file via api you do get an error message:

SCR-20221114-oj7

But in the app you only see a blank thumbnail and no image on the detail-page of the file:

SCR-20221114-ojr
SCR-20221114-ojz

It would be great if there was an error-icon as a thumbnail and a message on the detail-page (e.g. "Thumbnail cannot be shown because the image is larger than 6000px" – if that info is available to the app). In the current version Clients/Users are confused why their images are not showing up.

To Reproduce

Upload an image file that exceeds ASSETS_TRANSFORM_IMAGE_MAX_DIMENSION (default 6000px)

Errors Shown

No response

What version of Directus are you using?

9.20.4

What version of Node.js are you using?

v18.12.1

What database are you using?

SQLite

What browser are you using?

Chrome

How are you deploying Directus?

running locally

@rijkvanzanten
Copy link
Member

Linear: ENG-139

@jay-p-b-7span
Copy link
Contributor

@rijkvanzanten I have successfully solved this issue and screenshots have been attached. Please have a look.

Screnshots
image
image

PR #16843 Closes this issue.

@rijkvanzanten
Copy link
Member

Awesome!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
3 participants