Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NODE_ENV check in extensions auto reload #17102

Closed
rijkvanzanten opened this issue Jan 11, 2023 · 0 comments · Fixed by #21780
Closed

Remove NODE_ENV check in extensions auto reload #17102

rijkvanzanten opened this issue Jan 11, 2023 · 0 comments · Fixed by #21780
Assignees
@paescuj
Labels
🍰 Improvement 📁 Extensions

Comments

@rijkvanzanten
Copy link
Member

That check was added to avoid double reloading extensions in the source code dev mode powered by ts-node-dev, but it's causing some confusion elsewhere as NODE_ENV can be set to development for a range of different reasons.

I think we can drop the NODE_ENV flag check completely, but if not, lets make a Directus specific var check to rely on instead 👍🏻
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@paescuj paescuj

Labels
🍰 Improvement 📁 Extensions
Projects
Software Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable extensions auto reloading in dev mode directus/directus
2 participants
@paescuj @rijkvanzanten