Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment variable to configure the server shutdown timeout #17239

Closed
rijkvanzanten opened this issue Jan 19, 2023 Discussed in #17237 · 1 comment · Fixed by #18010
Closed

Add environment variable to configure the server shutdown timeout #17239

rijkvanzanten opened this issue Jan 19, 2023 Discussed in #17237 · 1 comment · Fixed by #18010
Assignees

Comments

@rijkvanzanten
Copy link
Member

The timeout ms of terminus is hardcoded to 1000 in the server shutdown. We should add a new SERVER_SHUTDOWN_TIMEOUT environment variable to configure this.

Discussed in #17237

Originally posted by onordgren January 19, 2023
Hello! We're running directus in k8s and would like to be able to control the timeout period in the terminus handler. From the source code it looks like it's hard coded at 1000ms. Is there some other recommended way of doing this, was thinking of maybe doing it in the server.stop hook. Or would you consider adding a configuration option to be able to set the terminus timeout?

@github-actions
Copy link

Linear: ENG-521

@Nitwel Nitwel self-assigned this Mar 31, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants