Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot select a foreign item when collection has a M2O to a singleton #17722

Closed
3 tasks done
jaads opened this issue Mar 7, 2023 · 3 comments · Fixed by #17790
Closed
3 tasks done

Cannot select a foreign item when collection has a M2O to a singleton #17722

jaads opened this issue Mar 7, 2023 · 3 comments · Fixed by #17790
Assignees
Labels

Comments

@jaads
Copy link
Member

jaads commented Mar 7, 2023

Checklist

Describe the Bug

When a collection referes to another collection with an MSO relationship, and the related collection is a singleton, the drawer of the M2O interface doesn't show the singleton item - the drawer is just blank.

Screen.Recording.2023-03-07.at.08.33.01.mov

To Reproduce

  1. Create a collection as and mark it as singleton
  2. Create another collection with a M2O relationship to the singleton collection
  3. Open the collection with the related singleton collection and click on the m2o interface.

The drawer will open but will not contain an item.
When the collection from step 1 is not a singleton, the behavior is as expected so the items will appear in the drawer and one can be selected. But when the collection is a singleton, no item is shown.

Hosting Strategy

Self-Hosted (Custom)

@jaads jaads added the 🍰 Bug label Mar 7, 2023
@jaads
Copy link
Member Author

jaads commented Mar 7, 2023

/linear

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

🤖 Linear issue created! Maintainers can access it here: ENG-789

@Nitwel Nitwel self-assigned this Mar 14, 2023
@Nitwel Nitwel added the App label Mar 14, 2023
@Nitwel
Copy link
Member

Nitwel commented Mar 14, 2023

I'm wondering what the right approach to solve this would be. We could fix the bug to support singletons in relations, but then you could end up with multiple singleton items in the database even though the app can only ever show one, which is not good at all. We could also do as the m2a is currently doing it by disallowing to select singletons on the relation which makes sense to me.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants