-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
discord auth #19224
Comments
When I copy paste those exact environment variables (even with This is most likely a deployment related issue rather than a bug in Directus 🤔 |
It’s really weird @rijkvanzanten I add that above like any other ENV and during finally deployment checks it fails and asks for client id. (This will fail a DO deployment) Been doing this for me since I started with directus. Only when I add discord. If I change it to openid I get a different error. So it’s def reading it. But if I change it back to oauth than it fails again asking for a client id that is def supplied. I’m wondering if it doesn’t like the client id for some reason? Every other provider I throw doesn’t do this haha. Let me try creating a new discord app and getting fresh client id. And check. It does build fine. But DO won’t deploy it because it keeps asking for client id. Idk lol |
So I deleted the old disord app and created a new one with new keys. Same issue. This is what I see. As soon as I add discord to the list of auths,
than I get the above error and the deployment fails. If I remove discord from the provider list and leave the rest of the above, it deploys fine (obviously as its not trying to add it as a provider) |
@BlackDahlia313 Can you try it with just |
checking meow |
just having discord there throws same thing. It just does not like discord it seems lol. I could try a fresh demo on railway instead of DO and test to see if it does the same thing. |
Confirmed it on a fresh demo railway deployment too. |
Very odd. Is there a chance that you have the same environment variable twice? Does it work when you rename it to something else (eg (In any case, I'll close this for now as it's most likely a configuration issue rather than a bug in Directus. Happy to reopen if it turns out to be otherwise) |
I didnt see this originally when searching. So my apologizes. We should maybe put a small callout in the sso docs that specifically calls out discord. (kinda like how theres one about github and emails) All is good now. But it is discord itself. so strange. Now the question is. should I leave it as dahlia or flip it back to discord lol xD |
Ahhhhhhh yes I now see it too! In my testing before, I had regular characters in the client_id to test if it was the variable not making it to the setting. That makes a ton of sense, as discord only uses numbers. Another point to implement #9521 sometime soon.. |
I knew I wasn't crazy! hahaha |
Describe the Bug
When trying to add discord as a SSO provider, deployment fails and asks for the client id, even tho one is specified.
Has anyone else seen this?
To Reproduce
Add discord as a sso provider and try to deploy
Directus Version
v10.4.3
Hosting Strategy
Self-Hosted (Docker Image)
The text was updated successfully, but these errors were encountered: