Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable field name translations to use "Custom translations" #19228

Open
rijkvanzanten opened this issue Jul 24, 2023 Discussed in #19226 · 2 comments
Open

Enable field name translations to use "Custom translations" #19228

rijkvanzanten opened this issue Jul 24, 2023 Discussed in #19226 · 2 comments

Comments

@rijkvanzanten
Copy link
Member

Discussed in #19226

Originally posted by ruihildt July 24, 2023

Summary

Custom translations are useful because you can centralize all translations in the same place.

Basic Example

No response

Motivation

Unfortunately, field name translations can't use the Custom translations.
So sometimes you will have to duplicate translations, and not every translations will be centralized in the same place.

Detailed Design

Next to the "Create new" button (or instead), add the translation icon to make it possible to select an existing custom translation

Requirements List

Must Have:

  • easy pick from the Custom translations

Drawbacks

No drawbacks. :)

Alternatives

Don't do anything and keep the issue unsolved.

Adoption Strategy

If you already have translation, I guess it would be nice to offer to add them to the Custom translations.
Ideally this could be automated.

We could imagine to auto-migrate all existing Field name translations, and use as the translation key the field key, and if there's already something with that key, add a simple increment (so field_1, field_2, etc.).

Unresolved Questions

No response

@Nitwel
Copy link
Member

Nitwel commented Aug 11, 2023

How would we approach this database whise as right now we store field translations in JSON. Changing that to string sounds like the optimal solution but would screw up existing implementations. Adding a new colum to fields sounds overly complicated. 🤔

@rijkvanzanten
Copy link
Member Author

Adding a new colum to fields sounds overly complicated. 🤔

I think we should do this! Just have a single "display name" column that's either a regular string, or one of those $t: strings that uses the custom translation naming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants