Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle extension labels as enabled when all nested packages are disabled #22569

Closed
licitdev opened this issue May 25, 2024 · 1 comment · Fixed by #22587
Closed

Bundle extension labels as enabled when all nested packages are disabled #22569

licitdev opened this issue May 25, 2024 · 1 comment · Fixed by #22587

Comments

@licitdev
Copy link
Member

Describe the Improvement

Bundle extensions label as enabled when all their nested packages are disabled.

image

However, when a nested package is enabled, it's labelled as partially enabled.

image

Perhaps the parent bundle extension's enabled status should be updated when a nested package is enabled and disabled. 🤔

@br41nslug
Copy link
Member

Perhaps the parent bundle extension's enabled status should be updated when a nested package is enabled and disabled. 🤔

This should already be happening 🤔 or at least when i reviewed the PR adding this feature, perhaps there is an edge case missing here
https://github.com/directus/directus/blob/main/api/src/services/extensions.ts#L248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants