Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot login if setting admin email with ".local" domain #6762

Closed
ansidev opened this issue Jul 12, 2021 · 3 comments
Closed

Cannot login if setting admin email with ".local" domain #6762

ansidev opened this issue Jul 12, 2021 · 3 comments

Comments

@ansidev
Copy link

ansidev commented Jul 12, 2021

Describe the Bug

Cannot login if setting admin email with ".local" domain

To Reproduce

  • Setting ADMIN_EMAIL using .local domain, ex: 'admin@example.local'
  • Start Directus.
  • Try to login and fails.

What version of Directus are you using?

v9.0.0-rc.83 (Docker)

What version of Node.js are you using?

Shipped with Docker image

What database are you using?

MariaDB 10.5

What browser are you using?

Chrome

What operating system are you using?

macOS

How are you deploying Directus?

docker-compose (locally)

@rijkvanzanten
Copy link
Member

The email address needs to be a valid email. .local isn't a valid TLD, so the email address is invalid and can't be used with Directus.

@ansidev
Copy link
Author

ansidev commented Jul 12, 2021

The email address needs to be a valid email. .local isn't a valid TLD, so the email address is invalid and can't be used with Directus.

@rijkvanzanten
That 's right but not for local development, and even if you want to apply this point, you should improve these things:

  • The message on error is not meaningful: "Wrong username or password". This is a bad message (wrong logical meaning) because it does not give the right information to the users, so it must be change.
  • There are many applications allow this email pattern on local development, so you should add a NOTICE to your document.

@rijkvanzanten
Copy link
Member

Feel free to open a PR or two 👍🏻

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants