Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release pipeline #6798

Closed
2 of 3 tasks
rijkvanzanten opened this issue Jul 14, 2021 · 5 comments · Fixed by #6813
Closed
2 of 3 tasks

Fix release pipeline #6798

rijkvanzanten opened this issue Jul 14, 2021 · 5 comments · Fixed by #6813
Assignees
Labels
Milestone

Comments

@rijkvanzanten
Copy link
Member

rijkvanzanten commented Jul 14, 2021

The improved build/release pipeline has a couple critical issues:

  • npm isn't authenticated as the correct user in the lerna publish step
  • the ARM docker image fails building
  • node-oracledb prevents image from being built

ref: #6759, #6796

@paescuj It seems like SQLite is trying to build the native dependencies from source, but fails doing so as Python isn't available on the image

cc @SeanDylanGoff @nickrum FWIW, the NPM token in the repo secrets is an Automation Token tied to my account.

@SeanDylanGoff
Copy link
Contributor

@rijkvanzanten OK let's debug the NPM issue first. I just tested with my own token, with this code: https://github.com/cynova/directus/blob/build-test/.github/workflows/release.yml
Can you maybe run this aswell? Should take < 1 min and we can exclude one possible error.

@rijkvanzanten
Copy link
Member Author

Should take < 1 min

It does mean pushing out new tags etc, not the quickest to do unfortunately.

Would it be easier to add a new action that has a manual trigger just to check the npm whoami?

@SeanDylanGoff
Copy link
Contributor

SeanDylanGoff commented Jul 14, 2021

Should take < 1 min

It does mean pushing out new tags etc, not the quickest to do unfortunately.

Hmm OK true especially without messing up the history.
I used git add --all && git commit -m test && git push && npx lerna version --exact --force-publish --yes patch to test quickly.

Would it be easier to add a new action that has a manual trigger just to check the npm whoami?

I guess that would also work

@SeanDylanGoff
Copy link
Contributor

@rijkvanzanten About ARM: Should we maybe just disable this for now?
Not sure if holding back rc-84 for it makes sense as there could be heaps of errors after the current one...

@rijkvanzanten
Copy link
Member Author

Yeah, might not be a bad idea, though... I think oracle, sqlite, and argon2 are the main dependencies that have a deeper native binding that needs building, so it might be worth fixing for Sqlite, and checking where that puts us

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants