Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colored dot favicon does not work if a custom module is loaded #8461

Closed
3 tasks done
christianrr opened this issue Sep 30, 2021 · 3 comments
Closed
3 tasks done

Colored dot favicon does not work if a custom module is loaded #8461

christianrr opened this issue Sep 30, 2021 · 3 comments
Assignees

Comments

@christianrr
Copy link
Contributor

Preflight Checklist

Describe the Bug

When a project color and logo is set, the favicon of the Admin App should appear as colored dot. However, this works only as long as no custom modules or interfaces are loaded.

If any plugins are included, the app watch handlers for serverStore in app.vue do not fire any more. For that reason, the favicon does not get replaced any more.

I assume, that there is an issue with the rollup plugin mechanism?

To Reproduce

  • Setup a clean Directus installation

  • Open it up and configure project color and logo

  • Logout from Admin App

  • Favicon is displayed as colored dot ✌️

  • Now, add a custom module (as described in the docs)

  • Restart Directus

  • Reload the Admin app

  • Default favicon is displayed, because serverStore watchers do not fire any more

What version of Directus are you using?

v9.0.0-rc95

What version of Node.js are you using?

v14.16

What database are you using?

MySQL 5.7

What browser are you using?

Chrome

What operating system are you using?

macOS

How are you deploying Directus?

locally

@rijkvanzanten
Copy link
Member

Very odd indeed. @nickrum any thoughts?

@nickrum
Copy link
Member

nickrum commented Sep 30, 2021

I can't think of a way in which extension loading could affect the serverStore. I'll take a look 👍

@rijkvanzanten
Copy link
Member

I can't reproduce this on 9.1.2 with a fresh setup. Would you be able to share the offending module that causes this behavior? Thanks!


Thank you for taking the time to submit this! Unfortunately, our team was not been able to reproduce it based on the information provided. Therefore, we will close this ticket for now, but will happily re-open it if new details are provided that allow us to reliably replicate the problem.

As a reminder:

  • Provide as much detail as possible in the issue description
  • Video screen captures and clear steps are very helpful
  • A full SQL dump is the fastest way for us to test/resolve (can be sent privately)
  • Make sure you are on the latest version of Directus
  • Did you try turning it off and on again?

This is an automated response.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants