Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WYSIWYG embedded images - private token appended twice #8653

Closed
3 tasks done
domdus opened this issue Oct 8, 2021 · 1 comment · Fixed by #9062
Closed
3 tasks done

WYSIWYG embedded images - private token appended twice #8653

domdus opened this issue Oct 8, 2021 · 1 comment · Fixed by #9062
Labels

Comments

@domdus
Copy link

domdus commented Oct 8, 2021

Preflight Checklist

Describe the Bug

When selecting an embedded image in WYSIWYG editor and click "image"-icon from the toolbar on top (right sidebar view opens), the access token param is appended twice. The image goes HTTP 500.

Image URL requested by sidebar view:
https://<DOMAIN>/assets/159ce235-9b5f-4dee-9d48-ff8de56a7509?access_token=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpZCI6ImM0NjZkMDQ3LWQwZGItNDliZC1iN2EyLWQ3NmQzMjMzZDdjMyIsImlhdCI6MTYzMzY5MjE4MSwiZXhwIjoxNjMzNjkzMDgxLCJpc3MiOiJkaXJlY3R1cyJ9.KIpMiYa1WiblxDLyEXqLn1cKSJh0YlM-03mIqBMfzMk&access_token=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpZCI6ImM0NjZkMDQ3LWQwZGItNDliZC1iN2EyLWQ3NmQzMjMzZDdjMyIsImlhdCI6MTYzMzY5Mjc5NSwiZXhwIjoxNjMzNjkzNjk1LCJpc3MiOiJkaXJlY3R1cyJ9.hIZoQhT4RfJ2FJxZ_5IpT-4z7R6IkgWL4B8iSE4Mt5c

image


Related issue/note:
Since the token is being appended, no further parameter is accepted in the URL. Try saving a URL with additional params lead to a complete app/browser freeze.

We were used add a Storage Asset Preset -key to emdedded images actually to optimize them in size.
Embed URL example:
https://<DOMAIN>/assets/159ce235-9b5f-4dee-9d48-ff8de56a7509?key=embedded-image-preset

To Reproduce

  • Embed an image in WYSIWYG editor
  • Click-select the image and click image-icon from toolbar to get the sidebar view

What version of Directus are you using?

v9.0.0-rc.95

What version of Node.js are you using?

14.15.4

What database are you using?

Postgres 13

What browser are you using?

Chrome

What operating system are you using?

Windows 10

How are you deploying Directus?

PaaS

@rijkvanzanten
Copy link
Member

@Nitwel Any thoughts?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants