Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comments to the .env file stub #13352

Merged
merged 15 commits into from May 31, 2022
Merged

Add comments to the .env file stub #13352

merged 15 commits into from May 31, 2022

Conversation

sxsws
Copy link

@sxsws sxsws commented May 17, 2022 •
edited

Adding comments to the vars in the .env file that is auto-generated when a project is created. See #13337

sxsws added 3 commits May 17, 2022 08:56
@sxsws
adding comments to env-stub
f097e6b 
to improve for autogenerated .env file during install - is this too verbose?
@sxsws
Merge pull request #1 from sxsws/sxsws-13337
05e370c 
[WIP] adding comments to env-stub
@sxsws
Completing adding comments to vars
68b580a
@sxsws sxsws marked this pull request as ready for review May 18, 2022 05:59
sxsws and others added 2 commits May 18, 2022 20:00
@sxsws @aidenfoxx
Update api/src/cli/utils/create-env/env-stub.liquid
562c300 
Co-authored-by: Aiden Foxx <aiden.foxx.mail@gmail.com>
@sxsws
Thanks to @aidenfoxx
6c2e720
rijkvanzanten
rijkvanzanten requested changes May 25, 2022
View reviewed changes
Copy link
Member

@rijkvanzanten rijkvanzanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start! Couple of small questions/tweaks, but nearly there 🙂

I also think we might want to drop the example.env file in favor of just having this stub act as both 👍🏻

api/src/cli/utils/create-env/env-stub.liquid Outdated Show resolved Hide resolved
api/src/cli/utils/create-env/env-stub.liquid Outdated Show resolved Hide resolved
api/src/cli/utils/create-env/env-stub.liquid Outdated Show resolved Hide resolved
@azrikahar azrikahar changed the title #13337 Adding comments to the .env file stub Add comments to the .env file stub May 26, 2022
@sxsws sxsws requested a review from rijkvanzanten May 31, 2022 15:51
@rijkvanzanten rijkvanzanten added this to the v9-next milestone May 31, 2022
@rijkvanzanten rijkvanzanten merged commit c42522d into directus:main May 31, 2022
@sxsws
Copy link
Author

sxsws commented May 31, 2022

Thanks, I wasn't sure whether to request the review or to leave it. Should I have done?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aidenfoxx aidenfoxx aidenfoxx left review comments

@rijkvanzanten rijkvanzanten rijkvanzanten approved these changes

Assignees

@br41nslug br41nslug

Labels
🍰 Improvement
Projects
None yet
Milestone
v9.12.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sxsws @aidenfoxx @rijkvanzanten @br41nslug