Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not all file types being imported #18

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

renet
Copy link
Contributor

@renet renet commented Dec 1, 2022

This PR removes the MIME-type filter for files being stored and cached as remote file nodes in Gatsby that was used to store only image files. It also cleans up the ´getAllImages` method that is no longer used.

I also considered renaming the "imageFile" prop, but did not do that for backward compatibility reasons.

Fixes #8, fixes ENG-59

Copy link
Contributor

@freekrai freekrai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with my test site and get images on the images and the ID returned for the video so looks good

@freekrai freekrai merged commit e61ea43 into directus:main Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gatsby-source-directus 9.14.4 returns null imageFile data for videos
2 participants