Skip to content
This repository has been archived by the owner on Jan 6, 2023. It is now read-only.

Preview Image is not regenerated after modifying the image #1080

Closed
Lapsus opened this issue Jul 3, 2019 · 5 comments
Closed

Preview Image is not regenerated after modifying the image #1080

Lapsus opened this issue Jul 3, 2019 · 5 comments
Labels
enhancement New feature or request

Comments

@Lapsus
Copy link
Contributor

Lapsus commented Jul 3, 2019

Bug Report

If you modify an image, the preview is not updated accordingly.

Steps to Reproduce

  1. Upload a image to the file browser.
  2. access the image via the file browser.
  3. edit the image, crop, rotate etc.

Expected Behavior

The preview image in the file browser (or a files interface) should show the updated, modified image.

Actual Behavior

The original image before the modification is shown.

Other Context & Screenshots

Technical Details

API Version: 2.2.1
APP Version: 7.6.1

  • Device: [eg: Desktop, iPhone6, etc]
  • OS: [eg: MacOS 10.13.6, Windows 10.1803]
  • Web Server: [eg: Apache 2.4.37]
  • PHP Version: [eg: 7.2.0]
  • Database: [eg: MySQL 8.0.12]
  • Install Method: [eg: cloned master branch]
@benhaynes benhaynes added the bug Something isn't working label Jul 3, 2019
@benhaynes benhaynes added this to Needs triage in Bug Triage via automation Jul 3, 2019
@hemratna hemratna moved this from Needs triage to Low priority in Bug Triage Jul 3, 2019
@hemratna
Copy link
Contributor

hemratna commented Jul 8, 2019

We are planning to change the underlying structure to create thumbnail #813.
So we might need to rework on this issue when we will make changes.
@benhaynes I am suggesting let's move this as a feature request dependent on #813.

@benhaynes
Copy link
Sponsor Member

I agree, this is not a bug since that's expected behavior. What we need is a thumbnail parameter to force generate. Something like:

200/200/contain/80?force=true
or...
200/200/contain/80?refresh=true

#813 is for the configuration of the thumbnail whitelist... so this refresh param doesn't rely on it. We could add this in before the new config if we wanted to.

@benhaynes benhaynes added enhancement New feature or request and removed bug Something isn't working labels Jul 8, 2019
@benhaynes benhaynes added this to Proposed in Feature Requests via automation Jul 8, 2019
@benhaynes benhaynes removed this from Low priority in Bug Triage Jul 8, 2019
@benhaynes
Copy link
Sponsor Member

To achieve better clarity/visibility, we are now tracking feature requests within the Feature Request project board.

This issue being closed does not mean it's not being considered.

@avonian
Copy link

avonian commented Sep 16, 2019

Hi there just wanted to follow up on this issue since it appears to be dependent on #813. Are there any workarounds we can use in the interim, or anything I or others can do to help bring about a resolution?

@benhaynes
Copy link
Sponsor Member

A PR would help! 😉

Otherwise, will get to this as soon as most of the larger bugs are closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
Feature Requests
Implemented
Development

No branches or pull requests

4 participants