Skip to content
This repository has been archived by the owner on Jan 6, 2023. It is now read-only.

Static tokens are not case sensitive #1928

Open
pzehle opened this issue Jun 12, 2020 · 2 comments
Open

Static tokens are not case sensitive #1928

pzehle opened this issue Jun 12, 2020 · 2 comments
Labels
api bug Something isn't working

Comments

@pzehle
Copy link

pzehle commented Jun 12, 2020

I have no idea if this is the right repo for this issue. I have a static token, I put it in the user in the database as explained in the docs, then when attempting to use it as Authorization: Bearer token, it does not check if the token is case sensitive or not. To reproduce, just use any token you want, and change a capital A for a small a, the check will pass and consider the token is correct.

Don't know if this is the right behavior, but I just wanted to point it out.

Latest version, Ubuntu.

Thanks!

@rijkvanzanten rijkvanzanten transferred this issue from another repository Jun 12, 2020
@rijkvanzanten
Copy link
Member

Not sure if this was designed like this, but it feels like a bug to me. I personally think the token should be case sensitive. What do you think @pzehle ?

@rijkvanzanten rijkvanzanten added the bug Something isn't working label Jun 12, 2020
@pzehle
Copy link
Author

pzehle commented Jun 12, 2020

@rijkvanzanten I totally agree. I feel this like a bug, because you lower the security of a token to probably half when it is not case sensitive. If this is planned then I would think this is not a good behavior.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants